Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Symfony 7 #77

Open
linawolf opened this issue Jan 27, 2024 · 3 comments
Open

Compatibility with Symfony 7 #77

linawolf opened this issue Jan 27, 2024 · 3 comments

Comments

@linawolf
Copy link

When running on TYPo3 v 12.4 with Symfony 7 I get a fatal errors:

PHP Fatal error: Declaration of IchHabRecht\Filefill\Command\ResetCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony
\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /var/www/html/vendor/ichhabrecht/filefill/Classes/Command/Reset
Command.php on line 52

Fatal error: Declaration of IchHabRecht\Filefill\Command\ResetCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Comp
onent\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /var/www/html/vendor/ichhabrecht/filefill/Classes/Command/ResetComma
nd.php on line 52

@linawolf
Copy link
Author

Adding :int as return value to all execute methods in command solves the problem locally

@linawolf
Copy link
Author

filefill-symfony7.patch

@IchHabRecht
Copy link
Owner

Hi @linawolf

Thank you for your issue. This problem should be fixed with the latest 4.3.1 release of filefill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants