Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove demo Dockerfile #287

Closed
lippserd opened this issue Oct 20, 2022 · 5 comments · Fixed by #289
Closed

Remove demo Dockerfile #287

lippserd opened this issue Oct 20, 2022 · 5 comments · Fixed by #289
Assignees
@Al2Klimov
Milestone
v1.2.2

Comments

@lippserd
Copy link
Member

No description provided.

@lippserd lippserd added this to the v1.2.2 milestone Oct 20, 2022
@lippserd lippserd mentioned this issue Oct 20, 2022
Merged
@Al2Klimov
Copy link
Member

Please consider keeping. It's a pretty convenient tool to show all theoretically possible graphs at once. Useful for developing/reviewing, e.g. #199.

@lippserd
Copy link
Member Author

I have no problem with having such an option, but not here. If it is useful for development, it should be included in our Docker dev setup. For the documentation readers, there should be screenshots showing the different templates.

@Al2Klimov
Copy link
Member

Even better! Can we postpone this until (a) docker dev env does the things Dockerfile.demo does atm?

@lippserd
Copy link
Member Author

No, because there is a release coming up.

@lippserd
Copy link
Member Author

See #288.

@Al2Klimov Al2Klimov self-assigned this Oct 20, 2022
@Al2Klimov Al2Klimov linked a pull request Oct 20, 2022 that will close this issue
Remove demo Dockerfile #289
Merged
@lippserd lippserd mentioned this issue Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Al2Klimov Al2Klimov

Labels
None yet
Projects
None yet
Milestone
v1.2.2
Development

Successfully merging a pull request may close this issue.

Remove demo Dockerfile Icinga/icingaweb2-module-graphite
2 participants
@lippserd @Al2Klimov