New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclosed files #85

Open

tpazderka opened this issue Nov 14, 2018 · 0 comments

Contributor

tpazderka commented Nov 14, 2018

The code leaves behind some unclosed files. This is a resource waste and produces warnings under Python 3.

Some examples in code:
https://github.com/IdentityPython/pyjwkest/blob/master/src/jwkest/jwk.py#L93
https://github.com/IdentityPython/pyjwkest/blob/master/src/jwkest/jwk.py#L164

And in tests:
https://github.com/IdentityPython/pyjwkest/blob/master/tests/test_2_jwk.py#L173
https://github.com/IdentityPython/pyjwkest/blob/master/tests/test_2_jwk.py#L297
https://github.com/IdentityPython/pyjwkest/blob/master/tests/test_3_jws.py#L632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment