Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs to start in desktop mode #498

Open
RiverExplorer opened this issue Feb 18, 2023 · 11 comments
Open

Needs to start in desktop mode #498

RiverExplorer opened this issue Feb 18, 2023 · 11 comments
Assignees
Labels
needinfo Further information is requested

Comments

@RiverExplorer
Copy link

Configuration

Wolvic version:
Wolvic build ID:

Hardware:

Steps to Reproduce

Current Behavior

Expected Behavior

Possible Solution

Context

Error Logs and Stack Traces

@svillar
Copy link
Member

svillar commented Feb 18, 2023

Could you please explain a little bit more what this is about? Is it a request?

@svillar svillar added the needinfo Further information is requested label Feb 18, 2023
@DWAAR
Copy link

DWAAR commented Feb 24, 2023

I think they're saying the browser should default to desktop mode, rather than defaulting to mobile-view webpages. Currently you have to go into the setting and check the desktop mode box every session, it doesn't appear to be sticky.

@svillar
Copy link
Member

svillar commented Feb 25, 2023

If that's the case then I'll close this as there are not plans to do so. We're talking about devices with limitted resources and interaction (input) constraints, so the mobile version provides much better experience in general. Thanks anyway for the suggestion.

@svillar svillar closed this as completed Feb 25, 2023
@RiverExplorer
Copy link
Author

RiverExplorer commented Feb 25, 2023 via email

@DWAAR
Copy link

DWAAR commented Feb 25, 2023

We'll have to agree to disagree about which is the appropriate mode for VR. My own personal preference for viewing webpages on a subjectively giant screen is not the page layout designed for 6" mobile screens.

Could the mode checkbox choice at least be sticky, so that users that choose to get pages in desktop layout only have to specify that once rather than every session?

@svillar
Copy link
Member

svillar commented Feb 25, 2023

OK, let's reevaluate it

@svillar
Copy link
Member

svillar commented Mar 6, 2023

@felipeerias Maybe we could add a new radio button in the settings to allow users to permanently select desktop mode as default, although there are also some other changes required in the machinery of the modes.

@felipeerias
Copy link
Collaborator

@svillar That could make sense, yes. It shouldn't be a big change.

One thing that I wanted to mention is that these modes not only change the user-agent but also how a page's viewport is calculated.

Mobile mode tries to follow the "viewport" meta tag provided by the website. For example, with mobile mode whatismyviewport.com reports a width of 800px at the default window size, which changes as you resize the window.

On the other hand, desktop mode forces the viewport to be always 980px wide, regardless of the size of the window (which seems weird?).

Unfortunately, I don't think that Gecko provides us with fine control over these behaviours.

@svillar
Copy link
Member

svillar commented Mar 9, 2023

@svillar That could make sense, yes. It shouldn't be a big change.

One thing that I wanted to mention is that these modes not only change the user-agent but also how a page's viewport is calculated.

Mobile mode tries to follow the "viewport" meta tag provided by the website. For example, with mobile mode whatismyviewport.com reports a width of 800px at the default window size, which changes as you resize the window.

On the other hand, desktop mode forces the viewport to be always 980px wide, regardless of the size of the window (which seems weird?).

Actually the viewport change is one of the things that guarantee that you get the "desktop" version of the page, which is want many users want, to get the same version of the page than in desktop.

Unfortunately, I don't think that Gecko provides us with fine control over these behaviours.

I think we should try to add the option of setting desktop mode permanently. I think that would be enough.

@RiverExplorer
Copy link
Author

RiverExplorer commented Mar 9, 2023 via email

@felipeerias
Copy link
Collaborator

We should also make it easier to change the display density value that we provide to the Web engine. It is already an option in the Display settings.

Responsive websites often take the viewport size into account when deciding whether to display the mobile or the desktop layout. Changing the display density makes the viewport larger from the point of view of the website, which means that it can accommodate more content.

At the default 1.0 density, the viewport has a size of 800x450:

viewport03

Responsive websites (e.g. dribble) use the mobile layout:

viewport01

Setting the display density to 0.75 gives us a viewport of size 1067x600:

viewport04

And responsive websites now can use a wider desktop/tablet layout:

viewport02

This setting is already implemented, but it is not well explained in the UI and changing it currently requires us to restart Wolvic (which doesn't actually work on some systems, the app just closes).

@HollowMan6 HollowMan6 self-assigned this Sep 24, 2023
HollowMan6 added a commit that referenced this issue Sep 25, 2023
If we are set the desktop mode as the default user agent mode
and we want to switch to mobile mode temporary, we then use the
VR user agent in this case.

Resolve #498

Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6 added a commit that referenced this issue Sep 25, 2023
If we set the desktop mode as the default user agent mode
and we want to switch to mobile mode temporarily, we then use the
VR user agent in this case.

Resolve #498

Signed-off-by: Songlin Jiang <[email protected]>
@HollowMan6 HollowMan6 removed their assignment Sep 26, 2023
HollowMan6 added a commit that referenced this issue Sep 29, 2023
If we set the desktop mode as the default user agent mode
and we want to switch to mobile mode temporarily, we then use the
VR user agent in this case.

Resolve #498

Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6 added a commit that referenced this issue Oct 2, 2023
If we set the desktop mode as the default user agent mode
and we want to switch to mobile mode temporarily, we then use the
VR user agent in this case.

Resolve #498

Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6 added a commit that referenced this issue Nov 7, 2023
If we set the desktop mode as the default user agent mode
and we want to switch to mobile mode temporarily, we then use the
VR user agent in this case.

Resolve #498

Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6 added a commit that referenced this issue Jan 24, 2024
If we set the desktop mode as the default user agent mode
and we want to switch to mobile mode temporarily, we then use the
VR user agent in this case.

Resolve #498

Signed-off-by: Songlin Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants