Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and resolve warnings for trackby functions in templates for pivot grid #15335

Open
dkamburov opened this issue Feb 4, 2025 · 1 comment
Assignees
Labels
grid: pivot ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@dkamburov
Copy link
Contributor

Investigate and resolve warnings for trackby functions in templates for pivot grid

@MayaKirova MayaKirova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Feb 5, 2025
@MayaKirova
Copy link
Contributor

@dkamburov @damyanpetev

In general since the pivot config is a complex object, once you start changing it runtime all inner object refs around the configuration change, hence it causes a full re-render in the different templates.

Around the idea of choosing some unique ids for the dimensions to track them by, originally I though that the memberName can be duplicated and is not a good id, since you can have different memberFunction to extract different values for each. However it seems that actually a scenario with duplicate memberName breaks the pivot:
https://stackblitz.com/edit/fnyrjhhu

And since it doesn't work anyway, I suggest we just document that it has to be unique and use it for the trackby function.

@MayaKirova MayaKirova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: pivot ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

No branches or pull requests

2 participants