Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a selected filter set is over the 65k manifest limit, the download links for individual studies/series are also disabled #1387

Open
pgundluru opened this issue May 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pgundluru
Copy link
Collaborator

Identified by Vamsi, Where NLST collection is having the disabled S5cmd box like below. Currently NLST is the only collection where this happens

image

@pgundluru pgundluru added bug Something isn't working triage needed Ticket needs to be reviewed by the developers and assigned to the proper milestone labels May 13, 2024
@s-paquette s-paquette changed the title In Prod, For NLST collection, there is 65k exceed messaging and download is disabled If a selected filter set is over the 65k manifest limit, the download links for individual studies/series are also disabled May 13, 2024
@s-paquette s-paquette removed the triage needed Ticket needs to be reviewed by the developers and assigned to the proper milestone label May 13, 2024
s-paquette added a commit that referenced this issue May 13, 2024
@s-paquette
Copy link
Member

Issue stemming from the same modal serving both options. Fix is building now.

@s-paquette
Copy link
Member

@pgundluru @fedorov This is now on test. Please note that to test this, you have to go through several steps to make sure all corner cases have been caught.

Note: This bug does NOT effect single series download, it only effects study manifest downloads. Additionally, it only effects study manifest downloads if the currently applied filters result in more than 65k series found. In other words, you will not see the bug if you a) select no filters, or b) select filters with a total series count of under 65k, or c) select filters over 65k, check the study manifest and find it broken, then reduce your series count via filters to back under 65k. The bug requires the current filtered series count to be over 65k to trigger.

Test cases:

  1. Select no filters. From the right hand tables choose a collection and case. The Download Images button should be disabled. Clicking on a study manifest link should produce a working dialog. NOTE: This works in production.
  2. Select filters totaling under 65k series. Open the main manifest export via Download Images. The s5cmd button should be working. Close the dialog. From the right hand tables choose a collection and case. Clicking on a study manifest link should produce a working dialog. NOTE: This works in production.
  3. Select filters totaling over 65k series. Open the main manifest export via Download Images. s5cmd download should be disabled. Close the dialog. From the right hand tables choose a collection and case. Clicking on a study manifest link should produce a working dialog. NOTE: This should be fixed on test but is broken in production.
  4. Repeat test 3's steps, but after closing the study manifest dialog, adjust the filters to reduce the series count to under 65k. Open the main manifest export via Download Images. The s5cmd button should be working. Close the dialog. From the right hand tables choose a collection and case. Clicking on a study manifest link should produce a working dialog. NOTE: This works in production.

@pgundluru pgundluru added the testing passed Functionality works as expected on the testing tier label May 15, 2024
@fedorov fedorov added this to the Release 44 milestone Aug 26, 2024
@s-paquette s-paquette removed the testing passed Functionality works as expected on the testing tier label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants