Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd bug #383

Open
SavageTheUnicorn opened this issue Jul 16, 2024 · 1 comment
Open

Odd bug #383

SavageTheUnicorn opened this issue Jul 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@SavageTheUnicorn
Copy link

Description

I've been using orebfuscator for a while and it works flawlessly for 99% of my players. Apparently not 1% though haha. It DOES work, and obfuscate ores and blocks but it's a bit wonky to say the least. A player sees an ore exposed to air and breaks it but it updates all blocks nearby back to their original. Video attached to show the issue.

5D8032A6-02BB-4C63-88B7-BD0B824722C3.mov

Reproduction Steps

I have not been able to reproduce this personally. The user uses vanilla minecraft, our server does have viaversion though.

Expected Behaviour

Ores show normally(maybe see a fake ore occasionally on bad wifi)

Orebfuscator Dump

https://gist.github.com/SavageTheUnicorn/07bc14e6d778adb197a6a7bf1bff9420

Extra Details

No response

@SavageTheUnicorn SavageTheUnicorn added the bug Something isn't working label Jul 16, 2024
@Ingrim4
Copy link
Member

Ingrim4 commented Jul 16, 2024

That's a well known problem with the disk cache because each cache entry only contains a hash of the current chunk and not the neighboring chunks. Meaning if you mine out a chunk perfectly inside the chunk border (16x16) and than rejoin the server that the neighboring chunks will still think they are up to date and serve the invalid cache entry. We looked at ways to mitigate that but weren't happy with the performance degradation so we didn't ship it.

You could disable disk cache (memory cache should be fine and can stay enabled) to mitigate this if it bothers you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants