PHP7.2 getAllOptions()

[Nuranto]

Already mentioned in #126 :

PHP Fatal error: Declaration of Mage_Customer_Model_Resource_Address_Attribute_Source_Country::getAllOptions() must be compatible with Mage_Eav_Model_Entity_Attribute_Source_Table::getAllOptions($withEmpty = true, $defaultValues = false) in magento/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Country.php on line 0

There is actually several classes like this...

[ivanweiler]

hey there, thx for reporting.

If you're looking for solution, please check develop branch, most of php 7.2 things is already resolved there

https://github.com/Inchoo/Inchoo_PHP7/tree/develop
https://github.com/Inchoo/Inchoo_PHP7/blob/develop/app/code/local/Mage/Eav/Model/Entity/Attribute/Source/Table.php#L49

[Nuranto]

Thanks! Is there a reason it's not released yet ? Something wrong, or missing ?

[Nuranto]

Note : codePool has been moved from local to community, however the extension is still located to local folder..

[ivanweiler]

🤦‍♂️ my bad, fixed 😅 thx for reporting

We're currently working with Magento directly on the official 7.2 patch. This will include some changes and a lot of additional testing across versions. So, hopefully, v.3.0 of this extension won't be needed

[Nuranto]

We're currently working with Magento directly on the official 7.2 patch

That's a great news, well done ! :)

[Nuranto]

Well, It's not in yesterday release 1.9.3.9 :'(

Do you have intel about ETA ? (:

[ivanweiler]

work in progress, sorry no dates yet

[jorgb90]

@ivanweiler Any updates on this?

[Nuranto]

Any updates ?
In 2 months~, PHP will stop delivering security fixes for 7.0 :(
Do you think a new Mage1 release with PHP7.1 or 7.2 support will arrive until then ?

[Tjitse-E]

@Nuranto , we're runningMagento 1.9.3.7 with Inchoo_PHP7 (v3 on the development branch) on PHP 7.1 and it works fine. If you can't wait until the new Magento 1 version, then I would suggest you just start patching your sites with the version that's currently on the development branch.

[hostep]

The official Magento patch for PHP 7.2 landed yesterday, see: https://magento.com/tech-resources/download#download2240

[m-overlund]

It won't make 1.9.3.10 which is due on monday, but will be included in next release.
https://twitter.com/piotrekkaminski/status/1040661286441414656

[durzel]

That's great news. So that patch/1.9.3.10 will obsolete this extension I presume. Curious to know whether the fixes will have been implemented the same way.