Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Topological order for totals calculation not in offical patch? #152

Open
stollr opened this issue Oct 15, 2018 · 2 comments
Open

Topological order for totals calculation not in offical patch? #152

stollr opened this issue Oct 15, 2018 · 2 comments

Comments

@stollr
Copy link

stollr commented Oct 15, 2018

In the README.md of this repository it says

Magento released official PHP 7.2 patches for Magento 1 (September 2018), which means this extension is not needed anymore!!

But as far as I can see, the fix for the topological order for the totals calculation (see 1c1c5e4) is not included in the official patch and has been reverted in master branch in commit 6b2fa1c.

What is the reason for that. Because in a shop, I am supporting, the old order fix does not fix the sorting with the third party extension Customweb/Subscriptions.

@seansan
Copy link

seansan commented Feb 22, 2019

can you find it in LTS? https://github.com/OpenMage/magento-lts

@stollr
Copy link
Author

stollr commented Feb 25, 2019

@seansan As far as I see it is not included there, too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants