From eafb4442b24b769363184ad5be4a2a30fd75a2b3 Mon Sep 17 00:00:00 2001 From: Junsu Park <101160207+JunJaBoy@users.noreply.github.com> Date: Tue, 9 Jul 2024 22:52:47 +0900 Subject: [PATCH 1/2] update KoinExtension.kt --- .../commonMain/kotlin/org/koin/core/extension/KoinExtension.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/core/koin-core/src/commonMain/kotlin/org/koin/core/extension/KoinExtension.kt b/projects/core/koin-core/src/commonMain/kotlin/org/koin/core/extension/KoinExtension.kt index a2e5dc923..2facde59a 100644 --- a/projects/core/koin-core/src/commonMain/kotlin/org/koin/core/extension/KoinExtension.kt +++ b/projects/core/koin-core/src/commonMain/kotlin/org/koin/core/extension/KoinExtension.kt @@ -25,7 +25,7 @@ import org.koin.core.Koin interface KoinExtension { /** - * register from Koin instance + * Register from Koin instance */ fun onRegister(koin : Koin) From 93f1dc1bdb5850543c86bca237d8ee6caca77ed2 Mon Sep 17 00:00:00 2001 From: Grzegorz Bobryk Date: Sun, 22 Sep 2024 17:24:39 +0200 Subject: [PATCH 2/2] [Maintenance] simplify `all` to `none` We can avoid negation in lambda by using `none` instead of `all`. --- .../src/commonMain/kotlin/org/koin/core/KoinLazyExt.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/core/koin-core-coroutines/src/commonMain/kotlin/org/koin/core/KoinLazyExt.kt b/projects/core/koin-core-coroutines/src/commonMain/kotlin/org/koin/core/KoinLazyExt.kt index c1d01e03a..3fe0cd35b 100644 --- a/projects/core/koin-core-coroutines/src/commonMain/kotlin/org/koin/core/KoinLazyExt.kt +++ b/projects/core/koin-core-coroutines/src/commonMain/kotlin/org/koin/core/KoinLazyExt.kt @@ -45,5 +45,5 @@ suspend fun Koin.onKoinStarted(block: suspend (Koin) -> Unit) { */ @OptIn(KoinInternalApi::class) fun Koin.isAllStartedJobsDone(): Boolean { - return coroutinesEngine.startJobs.all { !it.isActive } + return coroutinesEngine.startJobs.none { it.isActive } }