Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - enhance maintainability #76

Open
4 of 5 tasks
jubeira opened this issue Jan 2, 2019 · 2 comments
Open
4 of 5 tasks

Refactor - enhance maintainability #76

jubeira opened this issue Jan 2, 2019 · 2 comments

Comments

@jubeira
Copy link

jubeira commented Jan 2, 2019 •
edited
Loading

From #47 (review) (summary):

  • Use wstool to get system libraries.
  • Apply patches automatically.
  • Detect automatically which script to use (with or without toolchain) to create simpler build rules for libraries (libraries still need to be listed explicitly).
  • Rename build_cpp.sh to build_catkin_workspace.sh or build_ros_stuff.sh (for consistency with get_ros_stuff.sh).
  • Review and simplify scripts; place exports in config.sh and add some documentation.
This was referenced Jan 2, 2019
Merged
Merged
@ivanpauno
Copy link

"Apply packages automatically" means "Apply patches automatically", right?

@jubeira
Copy link
Author

jubeira commented Jan 9, 2019

Yes; thanks for the observation, edited now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jubeira @ivanpauno