Markup in i18n files.

[Ascor8522]

I believe Mediawiki and HTML markups should be left out of the internationalization files and hard-coded in the PHP files.

It could avoid errors while translating the strings and avoid repeating the same markup on multiple files.

Lines that would need to be changed:

mediawiki-scratch-login/i18n/en.json

Line 12 in 45a9ee4

"scratchlogin-instructions": "'''Note: You must already have an account on this wiki to log in with Scratch!'''<br/>Please comment the following verification code on the $1user verification project$2:<br/>'''$3'''<br/><small>(If necessary, you can [[Special:ScratchLogin/reset|reset your verification code]].)</small>",

mediawiki-scratch-login/i18n/en.json

Line 14 in 45a9ee4

"scratchlogin-unregistered": "The user '''$1''' is not registered on this wiki.",

mediawiki-scratch-login/i18n/en.json

Line 15 in 45a9ee4

"scratchlogin-success": "Success! You will be logged in as '''$1''' on the next page you visit.",

mediawiki-scratch-login/i18n/en.json

Line 16 in 45a9ee4

"scratchlogin-code-reset": "Your verification code has been reset.<br/>Return to [[$1]].",

mediawiki-scratch-login/i18n/en.json

Line 17 in 45a9ee4

"scratchlogin-userlogin-link": "<p class=\"mw-ui-vform\" style=\"text-align: center;\">[[Special:ScratchLogin|Log in with Scratch]]</p>",

mediawiki-scratch-login/i18n/en.json

Line 19 in 45a9ee4

"scratchpasswordreset-instructions": "Comment the following verification code on the $1user verification project$2 to be displayed a temporary password to log in with:<br/>'''$3'''<br/><small>(If necessary, you can [[Special:ScratchPasswordReset/reset|reset your verification code]].)</small>",

mediawiki-scratch-login/i18n/en.json

Line 21 in 45a9ee4

"scratchpasswordreset-success": "Your temporary password is '''<code>$1</code>'''. Please [[Special:UserLogin/$2|log in]] and change it as soon as possible.",

Also, keep in mind translating long strings isn't very user friendly, and it would be much more enjoyable to translate more smaller strings.

---

Checklist added by @Kenny2github:

• Split up scratchlogin-instructions
• Gender scratchlogin-unregistered
• Gender scratchlogin-success
• Use MediaWiki string for "return to page" if it exists and shorten scratchlogin-code-reset
• Hardcode styling for scratchlogin-userlogin-link
• Split up scratchpasswordreset-instructions
• Find a better way to introduce the user verification project than $1user verification project$2

[Kenny2github]

• I agree that scratchlogin-instructions should be split up. I will do this at some point.
• scratchlogin-unregistered is fine as it is. It's within limits of reasonable markup. However, it occurs to me that that string may need gendering. Will change that.
• Likewise for scratchlogin-success.
• I'm sure there's a MediaWiki built in string for "return to [[page]]", I just couldn't be bothered to find it when writing the extension. scratchlogin-code-reset will be shortened.
• scratchlogin-userlogin-link is not within limits for reasonable markup. That styling really should be hardcoded. In this case the link also can be. Will change.
• scratchpasswordreset-instructions should also be split up. Also, the $1user verification project$2 thing was a hack at the time. This extension is very new. Will change.
• scratchpasswordreset-success is within reasonable markup limits. No changes required for this.

If you don't mind, I will update your OP to reflect this as a checklist.