Follow-ups on create-testnet-data v1

[smelc]

Roadmap

• Revamp the create-staked command, to make its output easier to consume #473 (comment) (see also https://input-output-rnd.slack.com/archives/C031GFLC3DF/p1701118783237699) → Done in create-testnet-data: Make --stake-delegators write credentials to disk. Keep current behavior with new --transient-stake-delegators. #512
• Add create-testnet-data command #488 (comment)
• Revamp the create-staked command, to make its output easier to consume #473 (comment)
• Discuss the desired meaning of the --supply and the --supply-delegated flags. Do we want to keep the previous behavior that the total supply is --supply plus --supply-delegated? Or do we want --supply to be the real total supply and the non delegated supply to be --supply minus --supply-delegated? → Done in create-testnet-data: better UX for supply arguments #581
• Use create-testnet-data instead of create-staked in cardano-node here.
• Simplify the computation of the distribution: create-testnet-data: Make --stake-delegators write credentials to disk. Keep current behavior with new --transient-stake-delegators. #512 (comment)

Additional context

The first item above is kind about reintroducing IntersectMBO/cardano-node#4021, but behind a conditional flag:

Discussing this with @Jimbo4350 he came up with a glorious idea of having an option to write (or not) the delegated keys to disk. The current behavior is that it does not write them to disk after a request from the benchmarking team. Having this as an option gives us more flexibility for other use cases (i.e. tests) where we do need the stake keys available.

The last item above is about this remark from @carlhammann :

I can't comment directly on the line, because it's not (yet 😛) part of the diff, but the definition of distribution in the next line is an atrocity, IMO. It should be

distribution = concat $ zipWith (\params poolIx -> replicate (delegsForPool poolIx) params) >poolParams [1..]

or something similar, instead of relying on the semantics of list comprehensions with unused parameters.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

[smelc]

Closing as remaining improvements and checks have been done by @palas (see #646) and others the last weeks.