Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the files you download... #215

Open
Wild1145 opened this issue May 16, 2021 · 6 comments
Open

Validate the files you download... #215

Wild1145 opened this issue May 16, 2021 · 6 comments

Comments

@Wild1145
Copy link

Is your feature request related to a problem? Please describe.
Currently (As mentioned on my previous issue #214 ) You can download any file you want, even if it isn't an image. This results in me being able to download huge test files for example, which will never be rendered, and throw errors in the console.

Describe the solution you'd like
As an absolute minimum the plugin should validate the file extension to make sure that it is a valid image / gif / video. Ideally more sophisticated validation would be used to ensure that it is an actual valid image / gif / video, but anything would be better than the current state...

Describe alternatives you've considered
We're looking currently at maintaining our own fork for our server to maintain this functionality, which we'd like to avoid doing if it can be properly built into the original plugin.

Additional context
I managed to download a 10GB Hetzner test file by telling this plugin it was an image, downloaded it, filled up space on the disk, and errored out constantly on the console...

@stale
Copy link

stale bot commented Jul 21, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jul 21, 2021
@Wild1145
Copy link
Author

Wild1145 commented Jul 21, 2021 via email

@stale stale bot removed the wontfix label Jul 21, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 9, 2022
@Wild1145
Copy link
Author

Still Relevant.

@stale stale bot removed the wontfix label Jan 14, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Apr 16, 2022
@Wild1145
Copy link
Author

Wild1145 commented May 5, 2022

Still Relevant.

@stale stale bot removed the wontfix label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant