Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit on number of tiles #217

Open
Wild1145 opened this issue May 16, 2021 · 6 comments
Open

Limit on number of tiles #217

Wild1145 opened this issue May 16, 2021 · 6 comments

Comments

@Wild1145
Copy link

What steps will reproduce the problem?

We've identified bugs where if you try to set the tiles to be the world borders, it uses any memory the server has left. To make sure this doesn't happen and to make sure that we don't end up in a state where things are generally un-stable, we want to have a configurable limit.

What were you expecting to happen? What happened instead?

It to error out gracefully not take up all server memory and totally crash the server

What version of the plugin are you using? Type /version <Plugin Name>

4.13.0-SNAPSHOT (According to the spigot download anyway)

What Spigot version are you using? Type /version

Tested on multiple 1.16.5 Builds

What plugins are you using? Type /plugins

Various, but that's un-related to this bug...

Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log

Not to hand, easy enough to just re-produce...

Did your client crash? Upload errors in .minecraft/logs/latest.log as well

No

Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)

As you have to select the bottom left and top right tiles, We suggest a calculation to happen and work out the maximum number of tiles that might be affected and if that goes above the pre-configured number, fail fast and reject the request.

@stale
Copy link

stale bot commented Jul 21, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jul 21, 2021
@Wild1145
Copy link
Author

Wild1145 commented Jul 21, 2021 via email

@stale stale bot removed the wontfix label Jul 21, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 9, 2022
@Wild1145
Copy link
Author

Still Relevant.

@stale stale bot removed the wontfix label Jan 14, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Apr 16, 2022
@Wild1145
Copy link
Author

Wild1145 commented May 5, 2022

Still Relevant.

@stale stale bot removed the wontfix label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant