Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter customizations made through the Viewer are not included in downloaded STL file #606

Open
franknoirot opened this issue Mar 7, 2022 · 2 comments

Comments

@franknoirot
Copy link
Collaborator

Expected Behavior

When customizing the available parameters in the Viewer pane, especially the one available on a project's details page, I would expect those customized values to take effect on the downloaded file. However, you can only ever receive the file with the parameters described in the code.

Steps to reproduce

  1. Visit https://cadhub.xyz/u/franknoirot/silverware-drawer-divider.
  2. Adjust the silverware_sections to 4 from the default 3.
  3. Click Download.

The display of the model should upgrade to the STL view which is rad, but notice that the tray only has 3 sections.

Additional notes

  • It might be nice to provide a toast notification to the user that says "Downloading STL with customized parameters", so that if they tweaked them but actually wanted to download the original they can be reminded to reset those parameters.
  • This feels like a part of the UX that could use a lot of tightening: the relationship between the parameters and the download button feels pretty disconnected not just technically but in messaging, because they are. I hadn't really been designing them as the connected set of interactions that they really are. Worth thinking about how to make customizations as clear as possible.
@RagingRoosevelt
Copy link

I ran into this issue on my own file. Just a data point that it isn't happening just for you.

@drf5n
Copy link

drf5n commented Oct 17, 2022

I note that parameter customizations reset whenever I shrink/close the parameter window. Maybe the "reload each camera move?" code is starting things from scratch when you switch windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants