Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused code in figure_driver.py #172

Open
EdwardSafford-NOAA opened this issue Jan 5, 2024 · 0 comments
Open

Unused code in figure_driver.py #172

EdwardSafford-NOAA opened this issue Jan 5, 2024 · 0 comments

Comments

@EdwardSafford-NOAA
Copy link
Contributor

Description

Unless I'm missing something (which is distinctly possible) the following code in src/eva/plotting/batch/base/plot_tools/figure_driver.py doesn't do any harm but neither does it accomplish much of anything.

224 if key not in ['layers', 'mapping', 'statistics']:
225 if isinstance(value, dict):
226 getattr(plotobj, key)(**value)
227 elif value is None:
228 getattr(plotobj, key)()
229 else:
230 getattr(plotobj, key)(value)

In each of the 3 possible cases the return value from getattr() is not assigned, so I think this could all be safely removed.

Dependencies

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant