You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unless I'm missing something (which is distinctly possible) the following code in src/eva/plotting/batch/base/plot_tools/figure_driver.py doesn't do any harm but neither does it accomplish much of anything.
224 if key not in ['layers', 'mapping', 'statistics']: 225 if isinstance(value, dict): 226 getattr(plotobj, key)(**value) 227 elif value is None: 228 getattr(plotobj, key)() 229 else: 230 getattr(plotobj, key)(value)
In each of the 3 possible cases the return value from getattr() is not assigned, so I think this could all be safely removed.
Dependencies
None
The text was updated successfully, but these errors were encountered:
Description
Unless I'm missing something (which is distinctly possible) the following code in
src/eva/plotting/batch/base/plot_tools/figure_driver.py
doesn't do any harm but neither does it accomplish much of anything.224 if key not in ['layers', 'mapping', 'statistics']:
225 if isinstance(value, dict):
226 getattr(plotobj, key)(**value)
227 elif value is None:
228 getattr(plotobj, key)()
229 else:
230 getattr(plotobj, key)(value)
In each of the 3 possible cases the return value from getattr() is not assigned, so I think this could all be safely removed.
Dependencies
None
The text was updated successfully, but these errors were encountered: