From d7d821c3a36044e2223ea3af62df11577e55020e Mon Sep 17 00:00:00 2001 From: Masayuki Yamamoto <15698961+ma8ma@users.noreply.github.com> Date: Sat, 30 Dec 2023 23:51:49 +0900 Subject: [PATCH] Fix compiler warning for -Wsuggest-destructor-override part3 (#1312) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit オーバーライドしたデストラクタにoverrideキーワードが付いていないと コンパイラーに指摘されたため修正します。 clang-17のレポート (file pathを一部省略) ``` src/bbslist/addetcdialog.h:54:9: warning: '~AddEtcBBSMenuDialog' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override] 54 | ~AddEtcBBSMenuDialog() noexcept = default; | ^ ``` --- src/bbslist/addetcdialog.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bbslist/addetcdialog.h b/src/bbslist/addetcdialog.h index 46af2e747..6c84b7121 100644 --- a/src/bbslist/addetcdialog.h +++ b/src/bbslist/addetcdialog.h @@ -51,7 +51,7 @@ namespace BBSLIST public: AddEtcBBSMenuDialog( Gtk::Window* parent, const bool edit, const Glib::ustring& url, const Glib::ustring& name ); - ~AddEtcBBSMenuDialog() noexcept = default; + ~AddEtcBBSMenuDialog() noexcept override = default; std::string get_name() const { return m_entry_name.get_text(); } std::string get_url() const { return m_entry_url.get_text(); }