Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about gift_card#order_activatable? #62

Open
rounders opened this issue Nov 19, 2015 · 0 comments
Open

question about gift_card#order_activatable? #62

rounders opened this issue Nov 19, 2015 · 0 comments

Comments

@rounders
Copy link
Contributor

the order_activatable? method currently verifies that the gift card is not applied to an order that has a created_at date that is earlier than the gift card's created_at date. We're thinking of removing this check from a store that I'm working on because we've encountered a few cases now of customers not being able to use their gift card code due to that check. The most common case is something like this:

  • customer A visits the store for the first time on date x and hence a blank order is created in the system for that customer.
  • customer B purchases a gift card on date x + 1 and gives it to customer A.
  • customer A returns to the store and attempts to check out using the gift code but is told "The gift code you entered doesn't exist. Please try again." because their order.created_at is set to date x whereas giftcard.created_at is set to x + 1

I'm happy to submit a patch that removes this date related check in order_activatable? but I'm wondering if there's some reason that I'm overlooking as to why it would be a bad idea to do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant