Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Explore States Window when renaming states #54

Open
Vijayanth-Reddy-K opened this issue Feb 2, 2025 · 1 comment
Open

Update Explore States Window when renaming states #54

Vijayanth-Reddy-K opened this issue Feb 2, 2025 · 1 comment

Comments

@Vijayanth-Reddy-K
Copy link

Vijayanth-Reddy-K commented Feb 2, 2025

One additional bug regarding the State Machine that my colleagues at work highlighted to me when describing all the features they love about the JKI State Machine. (This was the only complaint/bug, FYI 🙂). The following was highlighted using the 2018 version of the SM, but it still remains today.

If I choose to explore states, like so:
Image

I get this:
Image

With this window open, if one goes and renames one of those listed states, say, Initialize Core Data to Initialize Data Core using the helper, it changes the state name everywhere: inside the case structure representing the state, and in every constant that is wired to Add States to Queue VI.

Well, everywhere BUT the above String Constant window. (A related sub-bug: Rename that window to "Linked States" or something more relevant, perhaps?)

Addendum: If I click on Find Callers on the right click menu for one of the states (UI: Front Panel State) from the above window, and rename, say, Macro Initialize, the Find Callers window does not update the name either.

I would hazard a guess that the scripting code does not update any popup dialogs at all.

The only way to get the updated name for now, is to open a new window.

@Vijayanth-Reddy-K
Copy link
Author

Vijayanth-Reddy-K commented Feb 2, 2025

Addendum to the above bug: This is more serious than I initially assumed. It is not merely cosmetic. Clicking on the old, "un-updated" name on the String Constant window takes me to the event structure, which is NOT where it is supposed to go.

(I was wondering if the navigation to states was due to some hidden tags that are not visible to the user, and not the state name. Seems not, if this is anything to go by..)

@Vijayanth-Reddy-K Vijayanth-Reddy-K changed the title Long standing bug (since 2018 SM atleast) that still persosts Long standing bug (since 2018 SM atleast) that still persists Feb 2, 2025
@Tom-McQuillan Tom-McQuillan changed the title Long standing bug (since 2018 SM atleast) that still persists Explore States Window does not update when renaming states Feb 3, 2025
@Tom-McQuillan Tom-McQuillan changed the title Explore States Window does not update when renaming states Update Explore States Window when renaming states Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant