Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Rename group" to group context menu and add keybinding for F2 #11896

Open
Siedlerchr opened this issue Oct 7, 2024 · 8 comments
Open

Add "Rename group" to group context menu and add keybinding for F2 #11896

Siedlerchr opened this issue Oct 7, 2024 · 8 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@Siedlerchr
Copy link
Member

Image

Is your suggestion for improvement related to a problem? Please describe.

Many applications (e.g. IntelliJ or VS Code offer a "rename option"

Describe the solution you'd like

  1. Add an option to rename the current group (Open the edit group window and directly select the group name text)
  2. Add a keybinding (F2)
    Bonus/Optional (not sure if this is possible): Make it in place renaming like in VS Code
@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. ui labels Oct 7, 2024
@Rydzard
Copy link

Rydzard commented Oct 7, 2024

hello @Siedlerchr , is this issue free ?

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@koppor koppor added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Oct 16, 2024
@Rydzard
Copy link

Rydzard commented Oct 29, 2024

Hi all, I’ve been a bit busy lately, so I couldn’t keep up with this issue, but I’ve created a basic prototype to show what it might look like. Let me know if this is in line with what you envisioned. I took some inspiration from IntelliJ and read that it would be ideal if pressing F2 worked like in VS Code. If I can’t implement that exact function, I’ll set it up so that pressing F2 opens a rename group window.

Here’s the link to the Figma and a video of the prototype. The window will look similar to the Edit Group window, but it will only allow renaming the group, with an OK button and an info link like in Edit Group.

Figma link: https://www.figma.com/proto/0g7oIphWjyCAXed7DPaumH/Untitled?node-id=10-3&t=SQnrK3XeU4WWpQyA-1

Video: https://github.com/user-attachments/assets/078d4cb1-50f5-4f4b-bd84-7f6f7bef4405

@Siedlerchr
Copy link
Member Author

Prototype looks good to me

@Rydzard
Copy link

Rydzard commented Nov 3, 2024

Hello. I wish you a good evening. I want to ask one thing, but rather explain how I should proceed, because I'm stuck on one part. I added the Rename Group option to the menu, I actually did the same thing as Edit Group, since I am inspired by Edit Group, and I also added my Dialog, which opens a window with Input in which we enter a new name, Cancel and OK button. And I just need to change the name of that group, as soon as I looked at the editGroup method in the GroupTreeViewModel class, the Dialog for the group actually opens there, and when changes are made, the inputs to this condition "newGroup.ifPresent(group -> { ", if I understand it well, of course. Only when I try the same for the renameGroup method, an error pops up, which I will also send as it looks like. I will also send the RenameGroupDialog as I created it. How would you advise me to change the name of that group when I enter input?

error: Image
renameGroupDialogView : RenameGroupView.txt

I also send GroupThreeViewModel where the condition is. Just importent part:

GroupTreeViw.txt

@Rydzard
Copy link

Rydzard commented Nov 4, 2024

Hello. I have already solved the previous problem, but another small problem occurred. When I enter a new name for the group, the structure goes to waste. You don't know how I could solve this problem?

I am sending a sample of the problem, for a better idea: https://github.com/user-attachments/assets/71c06fcf-c2dc-4141-b438-180534cdf663

@Siedlerchr
Copy link
Member Author

@Rydzard Can you please open a Pull Request with your code so far? Makes it easier for us to understand and reproduce it

@Rydzard
Copy link

Rydzard commented Nov 5, 2024

@Siedlerchr Hello there is pull request : #12159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Status: Assigned
Status: Normal priority
Development

No branches or pull requests

3 participants