Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the styling of components with the same variant #960

Closed
ffffffelix opened this issue Feb 12, 2025 · 0 comments · Fixed by #973
Closed

Unify the styling of components with the same variant #960

ffffffelix opened this issue Feb 12, 2025 · 0 comments · Fixed by #973
Assignees
Labels
design This is a design activity

Comments

@ffffffelix
Copy link
Collaborator

ffffffelix commented Feb 12, 2025

All components (input, dropdown, button) with the same variant (ghost, outlined) must have the same style.
Add scss variable to easily share style cross components.

For example, the Dropdown with the ghost variant should have the same style as the Button with the ghost variant.

Could you also check if we have other incoherences like that?

Idea:

  • Create a scss placeholder %ghost that can manage all states (:hover, :active, :focus) that can be used for all ghost components
@ffffffelix ffffffelix added the design This is a design activity label Feb 25, 2025
@Eevolee Eevolee self-assigned this Feb 26, 2025
@Eevolee Eevolee linked a pull request Mar 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is a design activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants