Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight input type #67

Open
blipinsk opened this issue Nov 18, 2019 · 2 comments
Open

Lightweight input type #67

blipinsk opened this issue Nov 18, 2019 · 2 comments

Comments

@blipinsk
Copy link

Have you considered having a lightweight version of input for this tool?

I'm thinking of something like all the important stats exported to a text file. Maintaining a bunch of apk snapshots (for comparisons) seems not to make any sense, when I could be maintaining a number of text files for a fraction of the cost.

If the lightweight input was available I could be keeping the text file for every single commit on master (or at least X last of them) and using it as the base for comparisons on my Pull Requests.

@JakeWharton
Copy link
Owner

I mentioned to someone about serializing the models to proto which would produce smaller files to retain. But that it was very, very low priority.

That being said, you already should only be keeping the last X of APKs for this tool anyway. The likelihood of someone branching from a commit that's more than a few hundred old is low, and even if that occurs you can fallback to either the oldest APK or the newest APK.

@blipinsk
Copy link
Author

I mentioned to someone about serializing the models to proto which would produce smaller files to retain. But that it was very, very low priority.

Noted.

That being said, you already should only be keeping the last X of APKs for this tool anyway. The likelihood of someone branching from a commit that's more than a few hundred old is low, and even if that occurs you can fallback to either the oldest APK or the newest APK.

The scale of the problem really depends on the APK size. Regardless of the apk storing "issue", uploading and downloading of 35+ MB apks (example of what I'm handling on a daily basis at the moment) would increase the usage of the precious CI time. Especially if there are multiple build types (apks) to be compared per master commit.

Anyhow... thanks for the response 👍

Goooler pushed a commit to Goooler/diffuse that referenced this issue Sep 10, 2022
…up.okio

Update dependency com.squareup.okio:okio to v3.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants