Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align size output #87

Open
JakeWharton opened this issue Aug 31, 2020 · 3 comments
Open

Align size output #87

JakeWharton opened this issue Aug 31, 2020 · 3 comments

Comments

@JakeWharton
Copy link
Owner

     arsc │   682 B │ 674 B │  -8 B │   576 B │   564 B │ -12 B
 manifest │   535 B │ 535 B │   0 B │ 1.1 KiB │ 1.1 KiB │   0 B

We should append two spaces to B so that the numbers line up vertically.

@JakeWharton
Copy link
Owner Author

But what if there are only B units in the column?

We could add a custom alignment strategy to picnic, perhaps.

@folecr
Copy link

folecr commented Sep 14, 2020

#97
You could re-use picnic's table alignment rules? I only added to the info command in this PR.

@folecr
Copy link

folecr commented Sep 14, 2020

$ ./build/libs/diffuse-test-binary.jar info ~/ws/playground/diffuse/test/app-debug.apk
app-debug.apk (signature: V1, V2)

 APK      │ compressed │ uncompressed
──────────┼────────────┼──────────────
      dex │    3.9 MiB │     9.5 MiB
     arsc │  442.8 KiB │   442.7 KiB
 manifest │    1.6 KiB │     5.5 KiB
      res │  779.5 KiB │     1.2 MiB
    asset │      0 B   │       0 B
    other │  127.5 KiB │   243.3 KiB
──────────┼────────────┼──────────────
    total │    5.2 MiB │    11.4 MiB

...

Goooler pushed a commit to Goooler/diffuse that referenced this issue Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants