Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Options for getFeaturesAtPointerEvent and getFeaturesAtLngLat are all or nothing #435

Closed
neodescis opened this issue Jan 22, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@neodescis
Copy link

Describe the bug
If specifying options for getFeaturesAtPointerEvent() or getFeaturesAtLngLat(), both pointerDistance and ignoreSelectFeatures must be specified according to the typings. Instead, both properties should be marked as optional, since there is logic to handle either being undefined.

Terra Draw npm version
1.0.0

To Reproduce
This errors when it should not:

terraDraw.getFeaturesAtPointerEvent(event.originalEvent, { ignoreSelectFeatures: false });
@neodescis neodescis added the bug Something isn't working label Jan 22, 2025
@neodescis neodescis changed the title [Bug] [Bug] Options for getFeaturesAtPointerEvent and getFeaturesAtLngLat are all or nothing Jan 22, 2025
@JamesLMilner
Copy link
Owner

You are right - should be a relatively easy fix. I will get to this in time for the next release.

@JamesLMilner
Copy link
Owner

JamesLMilner commented Jan 31, 2025

This is fixed and merged and will come out in the next release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants