Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spin up new DB containers on each test/CI! #638

Open
JaneJeon opened this issue Nov 18, 2021 · 1 comment
Open

Spin up new DB containers on each test/CI! #638

JaneJeon opened this issue Nov 18, 2021 · 1 comment
Labels
CI test the thing that nobody wants to do, but needs

Comments

@JaneJeon
Copy link
Owner

JaneJeon commented Nov 18, 2021 •
edited
Loading

With the following configs:

fsync = off
synchronous_commit = off

Plus, ensure the tests are architected in a way where it doesn't need the wipe script in the first place (AND it shouldn't be running its own delete queries!)
@JaneJeon JaneJeon self-assigned this Nov 25, 2021
@JaneJeon JaneJeon added CI test the thing that nobody wants to do, but needs labels Nov 25, 2021
@JaneJeon JaneJeon added this to the v1.3 milestone Dec 30, 2021
@JaneJeon JaneJeon removed their assignment Dec 30, 2021
@JaneJeon JaneJeon removed this from the v1.3 milestone Dec 30, 2021
@JaneJeon
Copy link
Owner Author

Plus, this would allow us to ditch knex-cleaner once and for all if we do this for development environments as well...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI test the thing that nobody wants to do, but needs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JaneJeon