-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Berkeley test failing: testConsistencyEnforcement #4153
Comments
FlorianHockmann
added a commit
that referenced
this issue
Nov 29, 2023
Some tests weren't executed prior to the JUnit update because they lacked the `@Test` annotation. I also added the `@Disabled` annotation to tests which were overriden with an empty test to show the intent for this. One test is failing with the added `@Test` annotation, but it was already failing before, but just wasn't executed. So, this now explicitly ignores the test, but we should of course still find out what the underlying problem is: #4153. Signed-off-by: Florian Hockmann <[email protected]>
FlorianHockmann
added a commit
that referenced
this issue
Dec 13, 2023
Some tests weren't executed prior to the JUnit update because they lacked the `@Test` annotation. I also added the `@Disabled` annotation to tests which were overriden with an empty test to show the intent for this. One test is failing with the added `@Test` annotation, but it was already failing before, but just wasn't executed. So, this now explicitly ignores the test, but we should of course still find out what the underlying problem is: #4153. Signed-off-by: Florian Hockmann <[email protected]>
FlorianHockmann
added a commit
to FlorianHockmann/janusgraph
that referenced
this issue
Dec 15, 2023
Some tests weren't executed prior to the JUnit update because they lacked the `@Test` annotation. I also added the `@Disabled` annotation to tests which were overriden with an empty test to show the intent for this. One test is failing with the added `@Test` annotation, but it was already failing before, but just wasn't executed. So, this now explicitly ignores the test, but we should of course still find out what the underlying problem is: JanusGraph#4153. Signed-off-by: Florian Hockmann <[email protected]> (cherry picked from commit acac893)
FlorianHockmann
added a commit
that referenced
this issue
Dec 15, 2023
Some tests weren't executed prior to the JUnit update because they lacked the `@Test` annotation. I also added the `@Disabled` annotation to tests which were overriden with an empty test to show the intent for this. One test is failing with the added `@Test` annotation, but it was already failing before, but just wasn't executed. So, this now explicitly ignores the test, but we should of course still find out what the underlying problem is: #4153. Signed-off-by: Florian Hockmann <[email protected]> (cherry picked from commit acac893)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This test is failing in #4135 which simply updates JUnit. However, this test already seems to fail on
master
, but for some reason it isn't executed there. I've noticed that IntelliJ complains about this test: Old style JUnit test method 'testConsistencyEnforcement()' in JUnit 4 class and its suggested fix simply adds the@Test
annotation to it. If I follow that suggestion and add the annotation, then the test is also executed onmaster
and fails there.So, it seems the JUnit update in #4135 just changes how JUnit discovers the tests which seems to include this test now. I suggest that we exclude the test now explicitly in #4135 so it doesn't stop us from updating JUnit and because this test has effectively been disabled for a long time already, but we should of course still look into it to find out why it is actually failing.
Stack Trace (if you have one)
The text was updated successfully, but these errors were encountered: