Removing TEAMCITY_PROJECT_NAME environment variable breaks other tools

[cezarypiatekGC]

Hi,

Can anyone explain why the TEAMCITY_PROJECT_NAME env variable is removed by this test adapter?

TeamCity.VSTest.TestAdapter/TeamCity.VSTest.TestLogger/Options.cs

Line 55 in 0716fdf

Environment.SetEnvironmentVariable("TEAMCITY_PROJECT_NAME", string.Empty);

The lack of this variable breaks other tools (for example ApprovalTests) which relays on this variable while discovering TC context.

Kind Regards,
Cezary

[NikolayPianikov]

Because some tools (for instance xUnit) use this variable and break TeamCity integration. It is better to use TEAMCITY_VERSION instead. I've created the PR: approvals/ApprovalTests.Net#617

[cezarypiatekGC]

It's over a year since I reported the issue and I again hit the problem that TEAMCITY_PROJECT_NAME is not available. Please restore this variable. If xUnit integration with TC is broken, then xUnit should be fixed instead of breaking everything around.