Always use compiler version as the max value for api level when known #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For figuring out the API level, we currently use the minimum of compiler version and the stdlib version module's library dependencies. This is an expensive operation and it can be avoided when we know the answer beforehand. My understanding is that we know the answer when compiler version is set explicitly (this is at least true for Gradle import case). In all other cases we can still use the old logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For figuring out the API level, we currently use the minimum of compiler version and the stdlib version module's library dependencies. This is an expensive operation and it can be avoided when we know the answer beforehand. My understanding is that we know the answer when compiler version is set explicitly (this is at least true for Gradle import case). In all other cases we can still use the old logic.