Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlickList appendTo prop doesn't work with Shadow DOM #189

Open
Geloosa opened this issue Apr 28, 2023 · 0 comments
Open

SlickList appendTo prop doesn't work with Shadow DOM #189

Geloosa opened this issue Apr 28, 2023 · 0 comments

Comments

@Geloosa
Copy link

Geloosa commented Apr 28, 2023

appendTo which is a query selector string doesn't work in Shadow DOM, as there's no way to select an element inside it just by a string, but a call to shadow host element's shadowRoot is required: document.querySelector("shadowHostSelector").shadowRoot.querySelector("appendToSelector").

If appendTo could receive HTMLElement reference directly, it would solve the issue.

Here's a PR for that: #188
@Geloosa Geloosa changed the title appendTo doesn't work with Shadow DOM SlickList appendTo prop doesn't work with Shadow DOM Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Geloosa