Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About image crop #8

Open
heguohao0728 opened this issue Apr 19, 2021 · 4 comments
Open

About image crop #8

heguohao0728 opened this issue Apr 19, 2021 · 4 comments

Comments

@heguohao0728
Copy link

heguohao0728 commented Apr 19, 2021

Sorry to disturbe you again..
I notice that you do crop during training and crop the image to 288x576.
I think this operation will lose the feature outside the 288x576, like the bule area:
微信截图_20210419175711
So why doing the crop like this? and I find that when testing, the image size is not been largely cropped (the size is 368x1232). Why the model trained by 288x576 can use on the 368x1232 and can still get the result? Is it because you also give the 1/n (1/16 in this case) disp when training?
Thanks.

@heguohao0728
Copy link
Author

And How to consider the camera parameters?
Because the camera which get datas in sceneflow datasets is different from the camera which is used in kitti datasets.
Why different camera with different camera parameters can share and train in the same net?

@JiaRenChang
Copy link
Owner

@heguohao0728

In training, we use "random" crop.

The model does not need camera parameters because it predict "disparity" where disparity = focal length * stereo camera distance / depth.

@heguohao0728
Copy link
Author

heguohao0728 commented Apr 20, 2021

Yes, I've known the formula.
Sorry I'm not discribing the question very well, but I mean the beseline length is the same in these two datasets? And the sceneflow has 15mm and 35mm focal length, kitti has the other.
You mean the focal length and the baseline length will not influence the net?

@JiaRenChang
Copy link
Owner

@heguohao0728
Yes, you can see the formula, the baseline and focal length are both normalized by depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants