Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch/button for changing between captive portal and scanning mode #13

Open
jpdias opened this issue Jul 28, 2022 · 2 comments
Open

Switch/button for changing between captive portal and scanning mode #13

jpdias opened this issue Jul 28, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@jpdias
Copy link

jpdias commented Jul 28, 2022

Add some mechanism (e.g. button, switch) for switching between captive portal and scanning mode without requiring to reboot the device. This also allows for the device to automatically enter in scanning mode on boot, and the user can change to captive when needed (e.g. with a two-state switch).

@JosephHewitt
Copy link
Owner

This is a good idea and something I had considered before but it does have an unfortunate downside: With the current PCBs, adding a switch won't be a very user-friendly thing to do meaning I expect most users won't do it. For that reason, this feature would have to be off by default and then enabled if needed.

My primary focus for now is to add features which will work on all wardrivers (eg, the "vanilla" devices) so this isn't something I will implement any time soon.

I'll leave this issue open and maybe someone else will implement it; I'll merge it in if I get a PR which doesn't affect vanilla devices.

@JosephHewitt JosephHewitt added the enhancement New feature or request label Jul 28, 2022
@jpdias
Copy link
Author

jpdias commented Jul 29, 2022

@JosephHewitt I totally concur with that approach, having something in the initial configuration screen to set the operation mode with or without the switch. If I got the time I will try to look into this enhancement in the terms presented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants