Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Documentation: eslint-plugin-regex vs eslint-plugin-regexp #1597

Open
2 tasks done
fb55 opened this issue Aug 3, 2024 · 6 comments
Open
2 tasks done

📝 Documentation: eslint-plugin-regex vs eslint-plugin-regexp #1597

fb55 opened this issue Aug 3, 2024 · 6 comments
Labels
area: documentation Improvements or additions to docs good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@fb55
Copy link

fb55 commented Aug 3, 2024

Bug Report Checklist

Overview

I am currently reading through the docs to see if I can pick up anything new.

https://github.com/JoshuaKGoldberg/create-typescript-app/blob/8404b1dbe654ec90786eabd82a6196c90bf97771/docs/Tooling.md#lint-regex states that:

eslint-plugin-regex: Detects issues with JavaScript regular expressions, such as potential exponential complexity.

https://github.com/gmullerb/eslint-plugin-regex allows files to be checked against regular expressions, and does not validate regular expressions. https://github.com/ota-meshi/eslint-plugin-regexp is the plugin that validates regular expressions.

Additional Info

No response
@fb55 fb55 added the area: documentation Improvements or additions to docs label Aug 3, 2024
@JoshuaKGoldberg
Copy link
Owner

Ha, nice spot! This is a pure docs issue. I slipped up and linked to the wrong plugin. It should be ota-meshi's eslint-plugin-regexp. Thanks for noting!

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Aug 3, 2024
@Krupakar-Reddy-S
Copy link

i would like to work on this

@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @fb55 for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Aug 7, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @fb55! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this issue Aug 7, 2024
@allcontributors
docs: add fb55 as a contributor for bug (#1600)
25f3781 
Adds @fb55 as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#1597 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@JoshuaKGoldberg
Copy link
Owner

@Krupakar-Reddy-S we don't have any issue claiming system (https://github.com/JoshuaKGoldberg/create-typescript-app/blob/212b5f7f767dd59473ec175408a6aa0e898fd0e5/.github/CONTRIBUTING.md#issue-claiming). If you've got a code change, you can go ahead and send a PR (please do!). 🚀

@JoshuaKGoldberg
Copy link
Owner

👋 ping @Krupakar-Reddy-S, still planning on sending a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: documentation Improvements or additions to docs good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fb55 @JoshuaKGoldberg @Krupakar-Reddy-S