Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal warns - tracking issue #2263

Closed
10 tasks
WRadoslaw opened this issue Feb 19, 2022 · 7 comments
Closed
10 tasks

Proposal warns - tracking issue #2263

WRadoslaw opened this issue Feb 19, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@WRadoslaw
Copy link
Contributor

WRadoslaw commented Feb 19, 2022

#2242
Warns to be covered:




#2324

#2325

  • Slash working group lead
    Same as when slashing a worker in group with given inputs, except
  • signer check,
  • worker corresponding to worker_id must be lead

#2326

  • Set Working Group Lead Reward
  • Same as when updating reward of a worker in group with given inputs, except signer check

#2327

  • Update Working Group Budget
  • If budget_update is non-negative, then this it must be no less than the council budget, otherwise the absolute value must be no less than the current group budget.

#2328

  • Set Membership Lead Invitation Quota
  • The membership working group has an assigned lead with membership id membership_id.

┆Issue is synchronized with this Asana task by Unito

@WRadoslaw WRadoslaw added enhancement New feature or request olympia labels Feb 19, 2022
@WRadoslaw WRadoslaw self-assigned this Feb 19, 2022
@WRadoslaw
Copy link
Contributor Author

@dmtrjsg

Does that design fulfills the expectations? Ofc message can be adjusted.

image

@bedeho bedeho removed the olympia label Feb 21, 2022
@bedeho
Copy link
Member

bedeho commented Feb 21, 2022

This should not be part of Olympia release, as it is not critical enough to block launch, so removing label.

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Feb 21, 2022

@WRadoslaw, comments from @MattAugustynowicz

Screenshot 2022-02-21 at 09 39 35

  • Let's not use capitals in the word "WARNING". I didn't find this writing structure in the draft, so we'll remain consistent here too. Let's just write "Warning"
  • The spacing between the checkbox icon and the text seems to be too large. In the project we have 4px spacing between the 24px icon and the text, so we can use that. But, if you used such checkboxes throughout the project, let's leave it like this 🙂

Copy in the "warning box": "Warning: Proposal parameters provided do not satisfy current runtime execution constraints. If the proposal was executed with the current runtime state, then it would get rejected automatically."

Copy in the "checkbox": "I understand this proposal will fail if execution constraints remain unchanged." Required =true to enable CTA "create proposal

  • Move checkbox to the bottom: like here:

Screenshot 2022-02-21 at 09 35 18

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Feb 21, 2022

@thesan @WRadoslaw as discussed this morning, it is more about validation on each field. Pls see comment from Bedeho:

What I am saying is that the inputted field values for the proposal parameters (in this case the specific proposal parameters), need to be validated against the execution conditions of the given proposal type, and this will require the validation logic in almost all cases actually fetching certain values from the runtime state. If the conditions are not satisfied, then you should make it hard for the user to proceed inadvertently.
So its really about blocking here, not explaining, people don't want things explained.

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Feb 24, 2022

#2305

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Feb 24, 2022

Closing this issue in favour of tracking each proposal type (with some exceptions for grouping similar ones) as separate issues, mapped to this (original ticket, which is now converted to epic) - #2328

@dmtrjsg dmtrjsg closed this as completed Feb 24, 2022
@dmtrjsg
Copy link
Contributor

dmtrjsg commented Feb 24, 2022

Closing this issue in favour of tracking each proposal type (with some exceptions for grouping similar ones) as separate issues, mapped to this (original ticket, which is now converted to epic) - #2328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants