-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal warns - tracking issue #2263
Comments
Does that design fulfills the expectations? Ofc message can be adjusted. |
This should not be part of Olympia release, as it is not critical enough to block launch, so removing label. |
@WRadoslaw, comments from @MattAugustynowicz
Copy in the "warning box": "Warning: Proposal parameters provided do not satisfy current runtime execution constraints. If the proposal was executed with the current runtime state, then it would get rejected automatically." Copy in the "checkbox": "I understand this proposal will fail if execution constraints remain unchanged." Required =true to enable CTA "create proposal
|
@thesan @WRadoslaw as discussed this morning, it is more about validation on each field. Pls see comment from Bedeho: What I am saying is that the inputted field values for the proposal parameters (in this case the specific proposal parameters), need to be validated against the execution conditions of the given proposal type, and this will require the validation logic in almost all cases actually fetching certain values from the runtime state. If the conditions are not satisfied, then you should make it hard for the user to proceed inadvertently. |
Closing this issue in favour of tracking each proposal type (with some exceptions for grouping similar ones) as separate issues, mapped to this (original ticket, which is now converted to epic) - #2328 |
Closing this issue in favour of tracking each proposal type (with some exceptions for grouping similar ones) as separate issues, mapped to this (original ticket, which is now converted to epic) - #2328 |
#2242
Warns to be covered:
amounts
Working Group Lead Proposals: cancel opening/ decrease stake/ terminate lead #2323
Cancel Working Group Lead Opening
Decrease Working Group Lead Stake
Terminate Working Group Lead
Same as when creating an opening for workers in the given group with given inputs, except signer check (?)
#2324
ℹ️ See details here> Create Working Group Lead Opening: Execution Constraints Validation #2280
#2325
Same as when slashing a worker in group with given inputs, except
#2326
#2327
#2328
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: