Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reported issues with the registry procedure #169

Open
tlienart opened this issue Jan 12, 2020 · 0 comments
Open

Reported issues with the registry procedure #169

tlienart opened this issue Jan 12, 2020 · 0 comments
Labels

Comments

@tlienart
Copy link
Collaborator

Below are some issues reported by a user "Y" trying to fully test that his interface to MLJ worked by setting up a local registry and checking that he could do "@load". I indicated that, for testing purposes, it was better to just go with the MLJBase API directly but the issues are still interesting for possible future improvements (PS: given that these issues are not mine, I may not be able to fully comment on them)

  1. trying to register an abstract model type as opposed to a full model type will fail in an obscure way --> cleaner error messages would be good
  2. the registry manifest h as examples of repeated symbols for the implemented_fields field
  3. maybe write explicitly how to fully test the model and that provided they can test it with just MLJBase it will necessarily work with @load or explain how they could locally test the @load.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant