Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maxnet.jl to the model registry #572

Closed
tiemvanderdeure opened this issue Oct 22, 2024 · 3 comments · Fixed by #581
Closed

Add Maxnet.jl to the model registry #572

tiemvanderdeure opened this issue Oct 22, 2024 · 3 comments · Fixed by #581
Assignees

Comments

@tiemvanderdeure
Copy link
Contributor

I implemented a MaxnetBinaryClassifier in my package Maxnet.jl. Can it be added to the registry?

I'm happy to make some tweaks if needed.

@ablaom
Copy link
Member

ablaom commented Oct 22, 2024

Thanks for working on an MLJ interface! Any chance you could add an interface test, as here? You'll need MLJTestInterface in your [extras].

@ablaom
Copy link
Member

ablaom commented Oct 22, 2024

Also, if you haven't already, an MLJ-compliant doc string which preferably includes a self-contained example. (Also helpful for our review).

@ablaom
Copy link
Member

ablaom commented Feb 12, 2025

Will act on this very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants