Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Metadata.jl #6

Open
Tokazama opened this issue Aug 3, 2021 · 12 comments
Open

Using Metadata.jl #6

Tokazama opened this issue Aug 3, 2021 · 12 comments

Comments

@Tokazama
Copy link
Member

Tokazama commented Aug 3, 2021

Hi @piever,

I a while back I made the Metadata.jl package. Currently it implements an array type that is nearly equivalent to MetadataArray. I'd like to propose having this package depend on Metadata.jl. It's a pretty light-weight package as is and I'm hoping to get it to a point where it's a common interface in the Julia ecosystem.

Let me know what you think and I'd be happy to make the PR.

@piever
Copy link
Collaborator

piever commented Aug 4, 2021

I confess I haven't used this package a lot in the past couple of years. To be honest, if Metadata.jl implements metadata arrays, I suspect MetadataArrays.jl doesn't really have much to add (the implementation seems extremely similar).

Maybe the most useful thing is to add to the README here that Metadata.jl is a more general approach to metadata that also includes array?

@Tokazama
Copy link
Member Author

Tokazama commented Aug 4, 2021

I'd be happy with either approach. MetadataArrays.jl was around first so I wanted to make sure you had input going forward.

@Tokazama
Copy link
Member Author

Tokazama commented Aug 2, 2022

@piever, with the upcoming addition of support of metadata in DataAPI.jl (JuliaData/DataAPI.jl#48), I'm trying to break up Metadata.jl into smaller pieces. Would you be interested in moving this to JuliaArrays and we could make this more official?

@piever
Copy link
Collaborator

piever commented Aug 3, 2022

Sure! I confess I don't really have the bandwidth to maintain MetadataArrays, so I'd be happy to move this to JuliaArrays.

Let me know if / when there is consensus among the JuliaArray devs on this and I'll transfer the repo (I should have the right privileges to do that).

@Tokazama
Copy link
Member Author

Tokazama commented Aug 3, 2022

I'll reach out on slack

@Tokazama
Copy link
Member Author

Thanks for moving this @piever! Would you prefer that I make PRs here and request you merge them or would you like me to take the lead on that going forward?

@piever
Copy link
Collaborator

piever commented Aug 18, 2022

No problem! Feel free to take the lead going forward (I really don't have the bandwidth for maintaining MetadataArrays).

@Tokazama
Copy link
Member Author

Sounds good. Can you give me permissions for this repo?

@piever
Copy link
Collaborator

piever commented Aug 22, 2022

I'd like to, but unfortunately I don't think I can do that (don't see the "Settings" tab for this repo, not sure why). You may need to ask to one of the JuliaArrays owners to get the permissions.

@Tokazama
Copy link
Member Author

You should have permissions to do so now.

@piever
Copy link
Collaborator

piever commented Sep 1, 2022

Sorry for the delay, I've been traveling in the past few days. You should have admin access to the repo now.

@Tokazama
Copy link
Member Author

Tokazama commented Sep 1, 2022

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants