New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iteration over CSF should also include core (?) #107

Open

jagot opened this issue Sep 5, 2022 · 1 comment

Member

jagot commented Sep 5, 2022

For some reason, I thought it logical to only loop over the peel:

AtomicLevels.jl/src/csfs.jl

Lines 115 to 117 in 0bb57c1

    
           Base.length(csf::CSF) = length(peel(csf.config)) 
        
           Base.getindex(csf::CSF, i::Integer) = 
        
               (peel(csf.config)[i],csf.subshell_terms[i],csf.terms[i])

This has now come back to bite me, and I think it would make more sense to loop over all subshells.

Member Author

jagot commented Sep 5, 2022

Granted, the core is closed and all subshells trivially couple to ¹S₀/0, but still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment