Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace configuration concatenation operator + with * #32

Open
jagot opened this issue Feb 28, 2019 · 0 comments
Open

Replace configuration concatenation operator + with * #32

jagot opened this issue Feb 28, 2019 · 0 comments

Comments

@jagot
Copy link
Member

jagot commented Feb 28, 2019

We want to go towards unsorted configurations, i.e. where no ordering of the orbitals is enforced, and concatenation of two configurations then become an illdefined operation, c.f. c"1s 2s" + c"1s 2p" vs c"1s 2p" + c"1s 2s". If no canonical ordering is enforced, the results would be different between these two operations, which would make the + operator non-commutative. To reduce confusion, the idea is to replace concatenation with + by *. This would also be more in line with Julia's string concatenation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants