Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure tests for plotting #76

Closed
mfalt opened this issue Jul 18, 2016 · 2 comments
Closed

Restructure tests for plotting #76

mfalt opened this issue Jul 18, 2016 · 2 comments
Assignees
Milestone

Comments

@mfalt
Copy link
Member

mfalt commented Jul 18, 2016

We are not allowed to checkout unregistered packages in the tests so have to change how we test the plots. The current structure is using the ControlExamplePlots.jl, we should restructure it so that we download specific versions of that repo instead of using Pkg.checkout. See discussion on pull request here and on Plots.jl here

This is urgent because of for example #75.

@mfalt mfalt added the urgent label Jul 18, 2016
@mfalt mfalt self-assigned this Jul 18, 2016
@mfalt mfalt removed the urgent label Jul 28, 2016
@mfalt
Copy link
Member Author

mfalt commented Jul 28, 2016

I fixed this now and we should be allowed to register the new version. We should however consider checking out specific versions of the test images. However, when the version of Plots.jl changes, the test will likely fail again, making it hard to verify old versions. We should probably wait with a long term solution until VisualRegressionTests.jl have converged on a solution.

@mfalt mfalt added this to the v0.3 milestone Aug 9, 2016
@mfalt mfalt mentioned this issue Aug 16, 2016
4 tasks
@baggepinnen
Copy link
Member

This issue seem stale, recent discussion in #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants