Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterator roadmap #151

Open
9 of 12 tasks
piever opened this issue Apr 3, 2018 · 0 comments
Open
9 of 12 tasks

Iterator roadmap #151

piever opened this issue Apr 3, 2018 · 0 comments

Comments

@piever
Copy link
Collaborator

piever commented Apr 3, 2018

List of things to do concerning the transition to a more Iterator based style.

Getting rid of inference:

Iterator compatibility / better composability:

  • Add method ndsparse(x) where x is an iterator that iterates pairs (Add method to collect iterator of pairs as ndsparse #157 )

  • Adapt flatten to also work when fed an iterator (so that when calling groupby with flatten=true we can skip one collect_columns step

  • Add option lazy=true to groupby, groupreduce, etc... to return the iterator rather than the collected version

  • See which functions can take an iterator as input. Decide what to do for those that cannot (for example groupby can't really be done on an iterator as we need the result of sortperm, but we could maybe add a trait to iterators to see if sortperm is known somehow, some sort of HasSortPerm())

Bugfixes:

  • Clarify situation for iterators of nested tuples/pairs

A concern is type piracy. For example, I would like to filter lazily and reduce in one go, but we can't add a reduce method for a general iterator as that's type piracy, so maybe we should define our own AbstractRowIterator for dispatch purposes. Then all lazy algorithms would return a subtype of AbstractRowIterator. Then maybe RowIterator(t, select) would iterate on Rows(t, select).

We also need to think hard as to what this would mean for the distributed case. I don't have a strong intuition about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant