Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot Observable(Pyramid) correctly #65

Open
felixcremer opened this issue Jan 22, 2025 · 2 comments
Open

Plot Observable(Pyramid) correctly #65

felixcremer opened this issue Jan 22, 2025 · 2 comments

Comments

@felixcremer
Copy link
Member

I would like to combine Observable and some data lazily, so that we can build dashboards on top of the Pyramid which would change the heatmap based on the values of some slider for example.
I can construct an Observable(Pyramid) but then the plotting would run into the DimArray fallback for plotting Observable(DimArray).

I am not sure, whether we would have to properly fix this by using the Makie recipe system properly instead of the dispatch on the Pyramid type on plot.

@meggart
Copy link
Member

meggart commented Jan 22, 2025

Looks like this is another case for not making Pyramids a DimArray

@felixcremer
Copy link
Member Author

I don't think, that this is the underlying problem it is rather that we didn't properly implement a Makie recipe for the Pyramid. We simply run into the next best thing which is the DimArray fallback.
If Pyramid would not be a subtype of AbstractDimArray we would simply fail in some lower level Makie code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants