Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another breakage w.r.t. Documenter v1 #82

Open
Datseris opened this issue Sep 27, 2023 · 1 comment
Open

Another breakage w.r.t. Documenter v1 #82

Datseris opened this issue Sep 27, 2023 · 1 comment

Comments

@Datseris
Copy link

Datseris commented Sep 27, 2023

After PR #81 my docs correctly install Documenter v1+ (https://github.com/JuliaDynamics/Attractors.jl/actions/runs/6321627234/job/17170682108?pr=94#step:4:331). However there is another breakage I can't seem to figure out:

https://github.com/JuliaDynamics/Attractors.jl/actions/runs/6321627234/job/17170682108?pr=94#step:5:1

To be clear of how we build the docs theme: we do

# Load documenter
using Documenter
using DocumenterTools: Themes
ENV["JULIA_DEBUG"] = "Documenter"
# download the themes
import Downloads
for file in ("juliadynamics-lightdefs.scss", "juliadynamics-darkdefs.scss", "juliadynamics-style.scss")
    Downloads.download("https://raw.githubusercontent.com/JuliaDynamics/doctheme/master/$file", joinpath(@__DIR__, file))
end
# create the themes
for w in ("light", "dark")
    header = read(joinpath(@__DIR__, "juliadynamics-style.scss"), String)
    theme = read(joinpath(@__DIR__, "juliadynamics-$(w)defs.scss"), String)
    write(joinpath(@__DIR__, "juliadynamics-$(w).scss"), header*"\n"*theme)
end
# compile the themes
Themes.compile(joinpath(@__DIR__, "juliadynamics-light.scss"), joinpath(@__DIR__, "src/assets/themes/documenter-light.css"))
Themes.compile(joinpath(@__DIR__, "juliadynamics-dark.scss"), joinpath(@__DIR__, "src/assets/themes/documenter-dark.css"))
@mortenpi
Copy link
Member

I think it's probably because your SCSS files are outdated. Basically, it looks like there is some conflict between your SCSS and the Documenter ones it pulls in. I also had to fix it for Documenter in JuliaDocs/Documenter.jl#2071 (comment) with JuliaDocs/Documenter.jl@8389ff0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants