From 64706d789f4816230d595b03f527fc0e9d934a3e Mon Sep 17 00:00:00 2001 From: Oscar Smith Date: Fri, 10 Jan 2025 14:14:07 -0500 Subject: [PATCH] remove fence that GC change made unnecessary (#56986) @gbaraldi and I think that this fence can probably be removed now that https://github.com/JuliaLang/julia/pull/55223 is merged. This should slightly expand the set of cases where the Memory is removable. --- src/cgutils.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/cgutils.cpp b/src/cgutils.cpp index 295dd93e869ba..98c5627578b80 100644 --- a/src/cgutils.cpp +++ b/src/cgutils.cpp @@ -4463,8 +4463,6 @@ static void emit_memory_zeroinit_and_stores(jl_codectx_t &ctx, jl_datatype_t *ty auto len_store = ctx.builder.CreateAlignedStore(nel, len_field, Align(sizeof(void*))); auto aliasinfo = jl_aliasinfo_t::fromTBAA(ctx, ctx.tbaa().tbaa_memorylen); aliasinfo.decorateInst(len_store); - //This avoids the length store from being deleted which is illegal - ctx.builder.CreateFence(AtomicOrdering::Release, SyncScope::SingleThread); // zeroinit pointers and unions if (zi) { Value *memory_ptr = ctx.builder.CreateStructGEP(ctx.types().T_jlgenericmemory, decay_alloc, 1);