Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`precompile´ should maybe error when given non type inputs? #57474

Open
KristofferC opened this issue Feb 20, 2025 · 4 comments
Open

`precompile´ should maybe error when given non type inputs? #57474

KristofferC opened this issue Feb 20, 2025 · 4 comments
Labels
compiler:inference Type inference compiler:precompilation Precompilation of modules needs decision A decision on this change is needed triage This should be discussed on a triage call

Comments

@KristofferC
Copy link
Member

julia> precompile(Tuple{typeof(Base.isequal), Int, Int})
true

julia> precompile(Tuple{typeof(Base.isequal), 1, 2})
false

Instead of returning false, maybe this should error since AFAIU these input are pretty much nonsense.

@NHDaly
Copy link
Member

NHDaly commented Feb 24, 2025

Is there still a decision needed here? Or can we agree on this as being desirable, and mark it as good-first-issue?

@NHDaly NHDaly added needs decision A decision on this change is needed compiler:precompilation Precompilation of modules compiler:inference Type inference labels Feb 24, 2025
@NHDaly
Copy link
Member

NHDaly commented Feb 24, 2025

CC: @vtjnash I think you might have decision-making ability here?

@vtjnash
Copy link
Member

vtjnash commented Feb 26, 2025

I don't think precompile having errors is a good or necessary idea. That usually has resulted in packages becoming un-installable and getting kicked out of PkgEval CI for no good reason.

@oscardssmith oscardssmith added the triage This should be discussed on a triage call label Feb 26, 2025
@oscardssmith
Copy link
Member

I think this should at least be a warnign, but tagging this for triage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference compiler:precompilation Precompilation of modules needs decision A decision on this change is needed triage This should be discussed on a triage call
Projects
None yet
Development

No branches or pull requests

4 participants