Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference for direct interpolation used #44

Open
mohamed82008 opened this issue Aug 2, 2018 · 2 comments
Open

Reference for direct interpolation used #44

mohamed82008 opened this issue Aug 2, 2018 · 2 comments

Comments

@mohamed82008
Copy link
Member

What is the reference for the direct interpolation used in this package? I see that it is an extension to non Z matrices but is there a paper or book that describes the rationale?

@learning-chip
Copy link

I found it in Trottenberg's Multigrid book -> Appendix A. An Introduction to Algebraic Multigrid (by Klaus Stuben) -> Section A.4.2 Direct Interpolation -> A.4.2.3 General case (compared to the more commonly-seen formula in Section A.4.2.1 M-matrices)

@termi-official
Copy link
Contributor

termi-official commented Jul 18, 2023

Sorry to bother, but I think the reference does not match the actual implementation. One of my students found this. I fail to understand the discrepancy, too. In these lines here

if sval < 0
Bx[nnz] = abs(neg_coeff * sval)
else
Bx[nnz] = abs(pos_coeff * sval)
end

Here an abs pops up (introduced in #43), while the original general formula given by Klaus Stuben's An Introduction to Algebraic Multigrid (A.4.2.3 - Equation 83f) states that the weights are signed, i.e.

$$w_{ik} = \begin{cases} - \alpha_i a_{ik} / a_{ii} & \text{if } k\in P_i^- \\\ - \beta_i a_{ik} / a_{ii} & \text{if } k\in P_i^+ \\\ \end{cases}$$

such that $w_{ik} &lt; 0$ for $k\in P_i^-$ and $w_{ik} &gt; 0$ for $k\in P_i^+$.

Can someone help me here what I got wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants