Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mathematical notation bugs in docs #72

Open
ahbarnett opened this issue Jan 25, 2022 · 1 comment
Open

mathematical notation bugs in docs #72

ahbarnett opened this issue Jan 25, 2022 · 1 comment

Comments

@ahbarnett
Copy link

Dear Tobias & crew,

I'm very glad you have mathematical descriptions of the transforms - this is essential for a professional math library.
But there are a bunch of typos in
https://github.com/JuliaMath/NFFT.jl/blob/master/docs/src/background.md
Mostly this is bold vs italic,
but also [-1/2,1/2) etc.

You may want to explain that there are other definitions,
eg
https://finufft.readthedocs.io/en/latest/math.html
and to tell the user to rescale their NU points to change definition.

I'll try to do a PR but may not be able to get to it :)

Keep up the good work. Best, Alex

@tknopp
Copy link
Member

tknopp commented Jan 25, 2022

Bold vs italic is a workaround since the math engine did not render the italic at some places...
Will fix that. I will definitely reference https://finufft.readthedocs.io/en/latest/math.html and discuss the scaling part.

No need to make PR at this point. Better would be if you could review the text when I finished the documentation (its work in progress).

One thing I stumbled upon when reading FINUFFT documentation is that you seem to support odd N. We need to reflect that in the mathematics. FINUFFT will actually be the only implementation supporting this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants