Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support key of type SubString{String} ? #35

Open
sjdaines opened this issue Apr 1, 2022 · 2 comments
Open

Support key of type SubString{String} ? #35

sjdaines opened this issue Apr 1, 2022 · 2 comments

Comments

@sjdaines
Copy link

sjdaines commented Apr 1, 2022

ERROR: MethodError: no method matching load_preference(::Module, ::SubString{String})
Closest candidates are:
load_preference(::Module, ::String) at C:\Users\Stuart.julia\packages\Preferences\TJoW1\src\Preferences.jl:35
load_preference(::Module, ::String, ::Any) at C:\Users\Stuart.julia\packages\Preferences\TJoW1\src\Preferences.jl:35

Perhaps just needs to use AbstractString instead of String ?
@sjdaines sjdaines changed the title key of type SubString{String} not accepted Support key of type SubString{String} ? Apr 1, 2022
@StefanKarpinski
Copy link

Should just be a matter of widening ::String annotations on methods to ::AbstractString.

@staticfloat
Copy link
Member

@sjdaines if you want to open a PR changing load_preference() to support AbstractString (and add a test for it) I'd be happy to review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@staticfloat @StefanKarpinski @sjdaines