You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And Symbolics depends on SymbolicUtils, and ModelingToolkit (MTK) depends on both SymbolicUtils and Symbolics.
version v0.18 of SymbolicUtils was released
CompatHelper opened a PRs 1 bumping the version in Symbolics, MTK and NeuralPDE, but the CI for this will fail because NeuralPDE depends on a Symbolics that does not yet support SymbolicUtils v0.18
a couple of days later Symbolics was updated to use it and generated a breaking release of Symbolics -- v4.0
CompatHelper opened a PRs 2 bumping only Symbolics in MTK and NeuralPDE, now the CI for this PR (which in theory should be good to go on MTK) will fail because the previous PR updating SU was not yet merged because it cannot be tested.
a few days later we manually updated ModelingToolkit and released version 7.0.0, at which point new PRs 3 was generated on NeuralPDE bumping only the MTK version -- again untestable because they still depend on Symbolics and SymbolicUtils which are not compatible with the new version of MTK.
A good solution would be:
When opening a version bump of Symbolics (v4.0) on package X, make sure that X all dependencies X and Symbolics share are also bumped to the highest version Symbolics requires in the same PR.
In this way the 3rd PR at least can be tested by CI.
Further, it can also be useful to just close the old PR (bumping SymbolicUtils) automatically when a new PR like the above bumps both Symbolics and SymbolicUtils together.
Take the example of NeuralPDE.jl https://github.com/SciML/NeuralPDE.jl/blob/master/Project.toml
it depends on SymbolicUtils, Symbolics, and ModelingToolkit
And Symbolics depends on SymbolicUtils, and ModelingToolkit (MTK) depends on both SymbolicUtils and Symbolics.
CompatHelper opened a PRs 1 bumping the version in Symbolics, MTK and NeuralPDE, but the CI for this will fail because NeuralPDE depends on a Symbolics that does not yet support SymbolicUtils v0.18
CompatHelper opened a PRs 2 bumping only Symbolics in MTK and NeuralPDE, now the CI for this PR (which in theory should be good to go on MTK) will fail because the previous PR updating SU was not yet merged because it cannot be tested.
A good solution would be:
When opening a version bump of Symbolics (v4.0) on package X, make sure that X all dependencies X and Symbolics share are also bumped to the highest version Symbolics requires in the same PR.
In this way the 3rd PR at least can be tested by CI.
Further, it can also be useful to just close the old PR (bumping SymbolicUtils) automatically when a new PR like the above bumps both Symbolics and SymbolicUtils together.
maybe related to #126 and others?
The text was updated successfully, but these errors were encountered: