Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm from all factor functions specific ::Tuple{..} on meas #621

Open
dehann opened this issue Sep 24, 2020 · 0 comments
Open

rm from all factor functions specific ::Tuple{..} on meas #621

dehann opened this issue Sep 24, 2020 · 0 comments

Comments

@dehann
Copy link
Member

dehann commented Sep 24, 2020

This is to allow dispatch use of MixtureRelative. This is good:

function (s::LinearRelative)( res::AbstractArray{<:Real},
                              userdata::FactorMetadata,
                              idx::Int,
                              meas::Tuple,                          # NOTICE HERE
                              X1::AbstractArray{<:Real,2},
                              X2::AbstractArray{<:Real,2}  )

This is bad:

function (s::LinearRelative)( res::AbstractArray{<:Real},
                              userdata::FactorMetadata,
                              idx::Int,
                              meas::Tuple{<:AbstractArray, ...},    # NOTICE HERE
                              X1::AbstractArray{<:Real,2},
                              X2::AbstractArray{<:Real,2}  )

This needs to be done for all factors in the ecosystem as well as noted in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant